crypto: fix webcrypto JWK EC and OKP import crv check - #43346
Merged
nodejs-github-bot merged 1 commit intoJun 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tniessen
approved these changes
Jun 9, 2022
15 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jun 16, 2022
PR-URL: #43346 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43346 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43346 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43346 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the JWK crv member is properly validated to match the algorithm.
For kty: EC this has to match the namedCurve property of the algorithm for both ECDSA and ECDH keys.
For kty: OKP this has to match the name of the algorithm.
Current behaviour is that the crv member is incorrectly ignored and may even be undefined.