doc: add F3n67u to triagers - #43350
Merged
aduh95 merged 1 commit intoJun 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
F3n67u
force-pushed
the
apply-for-a-triager
branch
from
b905aee to
1fecdfd
Compare
June 8, 2022 15:39
F3n67u
force-pushed
the
apply-for-a-triager
branch
from
1fecdfd to
58911e5
Compare
June 8, 2022 15:39
Ayase-252
approved these changes
Jun 8, 2022
Ayase-252
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
welcome
Sorry, something went wrong.
Trott
approved these changes
Jun 8, 2022
gireeshpunathil
approved these changes
Jun 8, 2022
marsonya
approved these changes
Jun 8, 2022
LiviaMedeiros
approved these changes
Jun 8, 2022
RaisinTen
approved these changes
Jun 9, 2022
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🎉
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
cc @nodejs/issue-triage |
Sorry, something went wrong.
meixg
approved these changes
Jun 9, 2022
VoltrexKeyva
approved these changes
Jun 9, 2022
VoltrexKeyva
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Welcome aboard!
Sorry, something went wrong.
aduh95
approved these changes
Jun 9, 2022
Copy link
Copy Markdown
Contributor
Author
|
Hi all! Is this pr ready to land? Is there anything else I need to do? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43350 ✔ Done loading data for nodejs/node/pull/43350 ----------------------------------- PR info ------------------------------------ Title doc: add F3n67u to triagers (#43350) Author Feng Yu (@F3n67u) Branch F3n67u:apply-for-a-triager -> nodejs:master Labels doc, author ready Commits 1 - doc: add F3n67u to triagers Committers 1 - Feng Yu PR-URL: https://github.com/nodejs/node/pull/43350 Reviewed-By: Qingyu Deng Reviewed-By: Rich Trott Reviewed-By: Gireesh Punathil Reviewed-By: Akhil Marsonya Reviewed-By: LiviaMedeiros Reviewed-By: Darshan Sen Reviewed-By: Xuguang Mei Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43350 Reviewed-By: Qingyu Deng Reviewed-By: Rich Trott Reviewed-By: Gireesh Punathil Reviewed-By: Akhil Marsonya Reviewed-By: LiviaMedeiros Reviewed-By: Darshan Sen Reviewed-By: Xuguang Mei Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 08 Jun 2022 15:38:13 GMT ✔ Approvals: 9 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000001553 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000153860 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000170079 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000247159 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000315148 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000694678 ✔ - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000696837 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000702516 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1001044269 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2480312874 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Landed in 440d95a. Thanks for volunteering, I've also added you to @nodejs/issue-triage. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@aduh95 Invitation accepted! Thank you all! Really excited to be part of the Node.js triage team. |
Sorry, something went wrong.
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43350 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43350 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43350 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43350 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I volunteer to become a triager of Node.js project.
My motivation is to support our users more and make more contributions to the node community.
I have read, understand, and will adhere to the Node.js project's Code Of Conduct.
Link to PR I made: https://github.com/nodejs/node/pulls/F3n67u