FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bootstrap: consolidate global properties definition by legendecas · Pull Request #43357 · nodejs/node · GitHub

/ node Public

bootstrap: consolidate global properties definition - #43357

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:global-process
ConversationCommits (1)ChecksFiles changed
Closed

bootstrap: consolidate global properties definition#43357
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:global-process

Conversation

legendecas commented Jun 9, 2022

Copy link
Copy Markdown
Member

globalThis.process and globalThis.Buffer has been re-defined with
a getter/setter pair.

atob and bota are defined as enumerable properties according to
WebIDL definition.

Refs: #26882
Refs: #37786 (comment)

nodejs-github-bot commented Jun 9, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 9, 2022
legendecas marked this pull request as ready for review June 9, 2022 04:01
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 9, 2022
aduh95 reviewed Jun 9, 2022
View reviewed changes
Comment thread lib/internal/bootstrap/node.js Outdated
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2022
aduh95 reviewed Jun 9, 2022
View reviewed changes
Comment thread lib/internal/bootstrap/node.js Outdated

nodejs-github-bot commented Jun 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44413/

aduh95 reviewed Jun 9, 2022
View reviewed changes
Comment thread lib/internal/bootstrap/node.js Outdated
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2022

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44418/

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44423/

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44425/

joyeecheung reviewed Jun 10, 2022
View reviewed changes
Comment thread lib/internal/bootstrap/node.js Outdated

joyeecheung Jun 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
// globalThis.process is been installed at `internal/bootstrap/pre_execution.js`.
// globalThis.process will be installed at `internal/bootstrap/pre_execution.js`.

joyeecheung Jun 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But why are we removing these anyway? Removing these results in a breaking change for the embedders, which is why the tests have to be updated.

legendecas Jun 10, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was reviewing the installation point of globalThis.process and globalThis.Buffer. It can be more intuitive to install them once rather than duplicate the installation.

It is true that removing can cause breaking changes on embedders with custom entry points. What do you think about moving the actual installation here?

joyeecheung Jun 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the reason that they are overriden in pre_execution is that we thought we were going to make this optional for ESM (probably behind flags), which didn't seem to happen...

legendecas Jun 11, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, that's true. From what I could tell, the current shape of the property descriptor is not going to be changed in anytime soon.

legendecas removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 10, 2022
legendecas force-pushed the global-process branch 2 times, most recently from c64d580 to 39394c2 Compare June 10, 2022 15:07
aduh95 reviewed Jun 10, 2022
View reviewed changes
Comment thread lib/internal/bootstrap/node.js Outdated
bootstrap: consolidate global properties definition
9c4ae03 
`globalThis.process` and `globalThis.Buffer` has been re-defined with
a getter/setter pair.

`atob` and `bota` are defined as enumerable properties according to
WebIDL definition.
github-actions Bot mentioned this pull request Jun 13, 2022
Open
15 tasks
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2022

legendecas commented Jun 13, 2022

Copy link
Copy Markdown
Member Author

Landed in 511e289

legendecas closed this Jun 13, 2022
legendecas added a commit that referenced this pull request Jun 13, 2022
bootstrap: consolidate global properties definition
511e289 
`globalThis.process` and `globalThis.Buffer` has been re-defined with
a getter/setter pair.

`atob` and `bota` are defined as enumerable properties according to
WebIDL definition.

PR-URL: #43357
Refs: #26882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
legendecas deleted the global-process branch June 13, 2022 16:07
github-actions Bot mentioned this pull request Jun 14, 2022
Open
16 tasks
danielleadams pushed a commit that referenced this pull request Jun 14, 2022
bootstrap: consolidate global properties definition
f7c4015 
`globalThis.process` and `globalThis.Buffer` has been re-defined with
a getter/setter pair.

`atob` and `bota` are defined as enumerable properties according to
WebIDL definition.

PR-URL: #43357
Refs: #26882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams mentioned this pull request Jun 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes
lpinca lpinca approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL