FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix typo in globals.md by daeyeon · Pull Request #43365 · nodejs/node · GitHub

/ node Public

doc: fix typo in globals.md - #43365

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
daeyeon:master.doc-220610.Fri.04ec
Jun 10, 2022
Merged

doc: fix typo in globals.md#43365
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
daeyeon:master.doc-220610.Fri.04ec

Conversation

daeyeon commented Jun 10, 2022

Copy link
Copy Markdown
Member

Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 10, 2022
marsonya added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jun 10, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @marsonya. Please 👍 to approve.

marsonya added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2022
nodejs-github-bot merged commit cb7e854 into nodejs:master Jun 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in cb7e854

daeyeon deleted the master.doc-220610.Fri.04ec branch June 10, 2022 10:48
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Jun 11, 2022
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: nodejs/node#43365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL