util: freeze kEnumerableProperty - #43390
Merged
LiviaMedeiros merged 1 commit intoJun 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
reviewed
Jun 12, 2022
Comment thread
test/parallel/test-internal-util-objects.js
Outdated
Comment on lines
32
to
40
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This doesn't really seem like something we need to care in our tests (in no credible scenario will anyone tries to check what's the value of Object.isSealed(kEnumerableProperty) in core, and if there was a way to make sure the object always behaves as we want it to that doesn't involve freezing it, that'd be fine too), the consequences are what's really important to test imo:
Suggested change
| assert.strictEqual( | |
| Object.isExtensible(kEnumerableProperty), | |
| false | |
| ); | |
| assert.strictEqual( | |
| Object.isSealed(kEnumerableProperty), | |
| true | |
| ); | |
| assert.strictEqual( | |
| Object.isFrozen(kEnumerableProperty), | |
| true | |
| ); | |
| assert.throws( | |
| () => { kEnumerableProperty.configurable = false; }, | |
| TypeError | |
| ); | |
| assert.throws( | |
| () => Object.assign(kEnumerableProperty, { configurable: false }), | |
| TypeError | |
| ); | |
| assert.throws( | |
| () => Object.assign(kEnumerableProperty, { enumerable: false }), | |
| TypeError | |
| ); |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Conceptually agreed. :)
My concern here is that by assuming alternatives to freezing and possibility of something dangerous (e.g. if there will be unavoidable exposing reference to kEnumerableProperty for userland) we must keep in mind every single way to break it.
If that approach will become common in core, we'll have to create an exhaustive isImmutable() helper function instead.
Sorry, something went wrong.
aduh95
approved these changes
Jun 12, 2022
aduh95
approved these changes
Jun 12, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Looks like CI got borked recently |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment was marked as duplicate.
benjamingr
approved these changes
Jun 13, 2022
jasnell
approved these changes
Jun 13, 2022
16 tasks
LiviaMedeiros
force-pushed
the
util-freeze-kenobirable-property
branch
from
174856c to
7a84b9b
Compare
June 14, 2022 15:07
This comment was marked as outdated.
BethGriggs
approved these changes
Jun 14, 2022
This comment was marked as outdated.
lpinca
approved these changes
Jun 14, 2022
17 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
PR-URL: nodejs#43390 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
LiviaMedeiros
force-pushed
the
util-freeze-kenobirable-property
branch
from
7a84b9b to
0f90879
Compare
June 15, 2022 08:42
22 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jun 16, 2022
PR-URL: #43390 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
31 tasks
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43390 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43390 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43390 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #43159 (comment)