src,bootstrap: remove `NodeMainInstance::registry_` by RaisinTen · Pull Request #43392 · nodejs/node · GitHub

All uses of NodeMainInstance::registry_ were removed in
43d2e24, so this change removes the variable completely.

Signed-off-by: Darshan Sen raisinten@gmail.com

All uses of NodeMainInstance::registry_ were removed in nodejs@43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <raisinten@gmail.com>

Fast-track has been requested by @jasnell. Please 👍 to approve.

CI: https://ci.nodejs.org/job/node-test-pull-request/44924/

Commit Queue failed

- Loading data for nodejs/node/pull/43392
✔  Done loading data for nodejs/node/pull/43392
----------------------------------- PR info ------------------------------------
Title      src,bootstrap: remove `NodeMainInstance::registry_` (#43392)
Author     Darshan Sen  (@RaisinTen)
Branch     RaisinTen:src,bootstrap/remove-NodeMainInstance-registry_ -> nodejs:main
Labels     c++, process, fast-track, author ready, needs-ci
Commits    1
 - src,bootstrap: remove NodeMainInstance::registry_
Committers 1
 - Darshan Sen 
PR-URL: https://github.com/nodejs/node/pull/43392
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43392
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Jun 2022 13:20:52 GMT
   ✔  Approvals: 5
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003640736
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003645749
   ✔  - Santiago Gimeno (@santigimeno): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003648118
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003985797
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1004606591
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-06-28T04:38:55Z: https://ci.nodejs.org/job/node-test-pull-request/44924/
- Querying data for job/node-test-pull-request/44924/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2583705616

Commit Queue failed

- Loading data for nodejs/node/pull/43392
✖  Failed to get collaborator info from nodejs/node/README.md
Error: Couldn't find ### TSC (Technical Steering Committee) in the README
    at parseCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:81:11)
    at getCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:59:21)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async PRData.getCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:74:26)
    at async Promise.all (index 0)
    at async PRData.getAll (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:58:5)
    at async getMetadata (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/components/metadata.js:18:3)
    at async main (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/components/git/land.js:200:22)

https://github.com/nodejs/node/actions/runs/2583778187

Landed in 08c8e85

All uses of NodeMainInstance::registry_ were removed in 43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43392 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

All uses of NodeMainInstance::registry_ were removed in nodejs/node@43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#43392 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

src,bootstrap: remove NodeMainInstance::registry_

9bbcca5

All uses of NodeMainInstance::registry_ were removed in nodejs@43d2e24, so this change removes the variable completely. Signed-off-by: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jun 12, 2022