crypto: test webcrypto ec raw public key import - #43405
Merged
nodejs-github-bot merged 1 commit intoJun 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment was marked as outdated.
jasnell
reviewed
Jun 13, 2022
Comment thread
test/parallel/test-webcrypto-export-import-ec.js
| Buffer.alloc(1, 0x04), | ||
| Buffer.from(jwk.x, 'base64url'), | ||
| Buffer.from(jwk.y, 'base64url'), | ||
| ]), |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Side note... It would be nice if Web Crypto supported using Blob for this kind of stuff.
Sorry, something went wrong.
jasnell
approved these changes
Jun 13, 2022
tniessen
approved these changes
Jun 13, 2022
Comment thread
test/parallel/test-webcrypto-export-import-ec.js
| Buffer.concat([ | ||
| Buffer.alloc(1, 0x04), | ||
| Buffer.from(jwk.x, 'base64url'), | ||
| Buffer.from(jwk.y, 'base64url'), |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
For hard-coded encoding/decoding mechanisms, it's usually a good idea to add a comment with a reference to a resource defining the relevant encoding.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
17 tasks
22 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jun 16, 2022
PR-URL: #43405 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43405 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43405 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43405 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for raw public EC key imports (both compressed and uncompressed).