test: mark test_buffer/test_finalizer flaky - #43414
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Refs: nodejs#43389 Mark new test as flaky as it seems to have had intermittent failures since it was added. Signed-off-by: Michael Dawson <mdawson@devrus.com>
Copy link
Copy Markdown
Member
Author
|
Proposing a fast track, please thumbs up if you agree. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
Sorry, something went wrong.
richardlau
approved these changes
Jun 13, 2022
tniessen
approved these changes
Jun 13, 2022
RaisinTen
approved these changes
Jun 14, 2022
benjamingr
approved these changes
Jun 14, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43414 ✔ Done loading data for nodejs/node/pull/43414 ----------------------------------- PR info ------------------------------------ Title test: mark test_buffer/test_finalizer flaky (#43414) Author Michael Dawson (@mhdawson) Branch mhdawson:aix-nodeapi -> nodejs:master Labels test, node-api, flaky-test, fast-track Commits 1 - test: mark test_buffer/test_finalizer flaky Committers 1 - Michael Dawson PR-URL: https://github.com/nodejs/node/pull/43414 Refs: https://github.com/nodejs/node/issues/43389 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43414 Refs: https://github.com/nodejs/node/issues/43389 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 13 Jun 2022 19:30:22 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43414#pullrequestreview-1004841589 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43414#pullrequestreview-1004844661 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43414#pullrequestreview-1005218252 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/43414#pullrequestreview-1005391903 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2493641879 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Jun 14, 2022
mhdawson
added a commit
that referenced
this pull request
Jun 14, 2022
Refs: #43389 Mark new test as flaky as it seems to have had intermittent failures since it was added. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43414 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 16, 2022
Refs: #43389 Mark new test as flaky as it seems to have had intermittent failures since it was added. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43414 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Refs: #43389 Mark new test as flaky as it seems to have had intermittent failures since it was added. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43414 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Refs: #43389 Mark new test as flaky as it seems to have had intermittent failures since it was added. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43414 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#43389 Mark new test as flaky as it seems to have had intermittent failures since it was added. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#43414 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #43389
Mark new test as flaky as it seems to have
had intermittent failures since it was added.
Signed-off-by: Michael Dawson mdawson@devrus.com