FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip test-net-connect-reset-until-connected on SmartOS by panva · Pull Request #43449 · nodejs/node · GitHub

/ node Public

test: skip test-net-connect-reset-until-connected on SmartOS - #43449

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:flaky-test-net-connect-reset-until-connected
Jun 19, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: skip test-net-connect-reset-until-connected on SmartOS#43449
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:flaky-test-net-connect-reset-until-connected

Conversation

panva commented Jun 16, 2022

Copy link
Copy Markdown
Member

Refs: #43446

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 16, 2022
panva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jun 16, 2022
panva requested a review from lpinca June 16, 2022 09:23

This comment was marked as outdated.

Sign in to view
lpinca approved these changes Jun 16, 2022
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine with this but it would be nice the find the cause.

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 16, 2022

This comment was marked as outdated.

Sign in to view

richardlau commented Jun 16, 2022

Copy link
Copy Markdown
Member

Nit: marking a test flaky doesn't skip it -- it changes how we treat failures for it.

panva commented Jun 16, 2022

Copy link
Copy Markdown
Member Author

Nit: marking a test flaky doesn't skip it -- it changes how we treat failures for it.

I guess the nit is for the commit message then? Shall I update it and re-run CI?

nodejs-github-bot commented Jun 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44616/

panva added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2022

lpinca commented Jun 16, 2022

Copy link
Copy Markdown
Member

As per #43446 (comment) and #43446 (comment) other tests are also timing out on "smartos20-64". I wonder if it makes sense to restart the machine.

panva removed the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2022
nodejs deleted a comment from github-actions Bot Jun 16, 2022
github-actions Bot mentioned this pull request Jun 17, 2022
Open
31 tasks

bnoordhuis commented Jun 17, 2022

Copy link
Copy Markdown
Member

FYI, I'm proposing in #43457 to simply drop smartos support.

panva commented Jun 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@bnoordhuis That's fine, but until then can we unjam CI/PRs by marking this test as flaky?

panva added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 17, 2022

github-actions Bot commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

This was referenced Jun 18, 2022
Open
Open
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 19, 2022

nodejs-github-bot commented Jun 19, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43449
✔  Done loading data for nodejs/node/pull/43449
----------------------------------- PR info ------------------------------------
Title      test: skip test-net-connect-reset-until-connected on SmartOS (#43449)
Author     Filip Skokan  (@panva)
Branch     panva:flaky-test-net-connect-reset-until-connected -> nodejs:main
Labels     test, flaky-test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-net-connect-reset-until-connected on SmartOS
Committers 1
 - Filip Skokan 
PR-URL: https://github.com/nodejs/node/pull/43449
Refs: https://github.com/nodejs/node/issues/43446
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43449
Refs: https://github.com/nodejs/node/issues/43446
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Jun 2022 09:22:01 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43449#pullrequestreview-1008839474
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-06-16T12:03:05Z: https://ci.nodejs.org/job/node-test-pull-request/44616/
- Querying data for job/node-test-pull-request/44616/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2523244812

aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2022
aduh95 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 19, 2022
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
nodejs-github-bot merged commit 2609dc6 into nodejs:main Jun 19, 2022

nodejs-github-bot commented Jun 19, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2609dc6

targos pushed a commit that referenced this pull request Jul 12, 2022
test: skip test-net-connect-reset-until-connected on SmartOS
b1a7798 
Refs: #43446

PR-URL: #43449
Refs: #43446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 31, 2022
test: skip test-net-connect-reset-until-connected on SmartOS
7cb71c0 
Refs: #43446

PR-URL: #43449
Refs: #43446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
test: skip test-net-connect-reset-until-connected on SmartOS
b067b9a 
Refs: #43446

PR-URL: nodejs/node#43449
Refs: nodejs/node#43446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva deleted the flaky-test-net-connect-reset-until-connected branch October 13, 2022 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL