events: improve Event compatibility - #43461
Merged
nodejs-github-bot merged 1 commit intoJul 8, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mscdex
reviewed
Jun 17, 2022
Comment thread
lib/internal/event_target.js
Outdated
aduh95
approved these changes
Jun 17, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
LiviaMedeiros
approved these changes
Jun 17, 2022
lpinca
approved these changes
Jun 17, 2022
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: can you please rename test-event-whatwg-constructors.js to test-whatwg-event-constructors.js? For consistency with the existing test-whatwg-url-constructor.js.
Sorry, something went wrong.
34 tasks
Copy link
Copy Markdown
Member
Author
|
It looks better for consistency. Applied the suggestion. Thanks! Actually, it was named by following test-eventtarget-whatwg-xxx.jss. 😂 Maybe worth renaming such files to avoid confusion. |
Sorry, something went wrong.
daeyeon
force-pushed
the
main.web.event-220617.Fri.3c24
branch
from
49682ce to
a4b26cb
Compare
June 18, 2022 01:34
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
daeyeon
force-pushed
the
main.web.event-220617.Fri.3c24
branch
from
a4b26cb to
b9a0f37
Compare
June 18, 2022 01:51
Copy link
Copy Markdown
Member
Author
|
I squashed the fixup commits and added a commit to rename the files mentioned above. @lpinca PTAL, and, if it's reasonable, could you remove the commit-queue-squash tag? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@daeyeon can you please move events: rename test-eventtarget-whatwg-xxx.js to a separate PR? |
Sorry, something went wrong.
daeyeon
force-pushed
the
main.web.event-220617.Fri.3c24
branch
from
b9a0f37 to
2d372b3
Compare
June 18, 2022 05:54
lpinca
approved these changes
Jun 18, 2022
Copy link
Copy Markdown
Member
Author
|
@lpinca Thanks for the review, updated! |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Jun 19, 2022
jasnell
approved these changes
Jun 27, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
23 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43461 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 18, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43467 Refs: #43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43461 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This renames some test filenames to align with the existing `parallel/test-whatwg-*.js` for consistency. According to the comment in each file, they are seemingly manually ported from the `wpt@dom/events` tests. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#43467 Refs: nodejs/node#43461 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#43461 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Event constructor to improve Event Web API compatibility.
The test added was written by referring to wpt@dom/events/Event-constructors.any.js
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com