src: improve and update ByteSource description - #43478
Merged
nodejs-github-bot merged 1 commit intoJun 25, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Clarify that external data must not be destroyed before the ByteSource that points to it, and that allocated data must have been allocated using OpenSSL's allocator (because it will be freed automatically, using OpenSSL's memory management functions). Also add a brief description of the new ByteSource::Builder class.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
30 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
36 tasks
RaisinTen
approved these changes
Jun 20, 2022
This was referenced Jun 21, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Clarify that external data must not be destroyed before the ByteSource that points to it, and that allocated data must have been allocated using OpenSSL's allocator (because it will be freed automatically, using OpenSSL's memory management functions). Also add a brief description of the new ByteSource::Builder class. PR-URL: #43478 Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Clarify that external data must not be destroyed before the ByteSource that points to it, and that allocated data must have been allocated using OpenSSL's allocator (because it will be freed automatically, using OpenSSL's memory management functions). Also add a brief description of the new ByteSource::Builder class. PR-URL: #43478 Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Clarify that external data must not be destroyed before the ByteSource that points to it, and that allocated data must have been allocated using OpenSSL's allocator (because it will be freed automatically, using OpenSSL's memory management functions). Also add a brief description of the new ByteSource::Builder class. PR-URL: nodejs/node#43478 Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that external data must not be destroyed before the ByteSource that points to it, and that allocated data must have been allocated using OpenSSL's allocator (because it will be freed automatically, using OpenSSL's memory management functions).
Also add a brief description of the new ByteSource::Builder class.