FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: update wpt tests for encoding by F3n67u · Pull Request #43484 · nodejs/node · GitHub

/ node Public

test: update wpt tests for encoding - #43484

Closed
F3n67u wants to merge 1 commit into
nodejs:mainfrom
F3n67u:wpt-encoding
Closed

test: update wpt tests for encoding#43484
F3n67u wants to merge 1 commit into
nodejs:mainfrom
F3n67u:wpt-encoding

Conversation

F3n67u commented Jun 19, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

The PR:
1. update WPT test for encoding and resources to latest commit: automated by git node wpt
2. add isShadowRealm to global.GLOBAL to avoid wpt test crash: without this property test will fail with global.GLOBAL.isShadowRealm is not a function see https://github.com/web-platform-tests/wpt/blob/master/resources/testharness.js#L544

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 19, 2022
F3n67u marked this pull request as ready for review June 19, 2022 11:11
F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022

Copy link
Copy Markdown
Collaborator

F3n67u commented Jul 24, 2022

Copy link
Copy Markdown
Contributor Author

Close in favor of #43958

F3n67u closed this Jul 24, 2022
F3n67u deleted the wpt-encoding branch July 24, 2022 05:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL