FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update OpenSSL 3.0.4+quic by RafaelGSS · Pull Request #43536 · nodejs/node · GitHub

/ node Public

deps: update OpenSSL 3.0.4+quic - #43536

Closed
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:update-openssl-3-0-4
ConversationCommits (2)ChecksFiles changed
Closed

deps: update OpenSSL 3.0.4+quic#43536
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:update-openssl-3-0-4

Conversation

RafaelGSS commented Jun 22, 2022

Copy link
Copy Markdown
Member

Updated openssl dep to openssl-3.0.4p+quic using the maintenance guide.

Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-June/000228.html

RafaelGSS added 2 commits June 22, 2022 11:44
deps: upgrade openssl sources to quictls/openssl-3.0.4
467f2e0 
This updates all sources in deps/openssl/openssl by:
    $ git clone git@github.com:quictls/openssl.git
    $ cd openssl
    $ git checkout openssl-3.0.4+quic
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../../../openssl openssl
    $ rm -rf openssl/.git* openssl/.travis*
    $ git add --all openssl
    $ git commit openssl
deps: update archs files for quictls/openssl-3.0.4+quic
0a1571e 
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl
    $ git commit

nodejs-github-bot commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Jun 22, 2022
aduh95 changed the title deps: update OpenSSL 1.1.1p+quic deps: update OpenSSL 3.0.4p+quic Jun 22, 2022
richardlau changed the title deps: update OpenSSL 3.0.4p+quic deps: update OpenSSL 3.0.4+quic Jun 22, 2022
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2022

nodejs-github-bot commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44805/

richardlau added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 22, 2022

tniessen commented Jun 22, 2022

Copy link
Copy Markdown
Member

The diff size always bothers me. Hundreds of thousands of lines...

github-actions Bot mentioned this pull request Jun 23, 2022
Open
33 tasks

nodejs-github-bot commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44815/

nodejs-github-bot commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44816/

RafaelGSS commented Jun 23, 2022

Copy link
Copy Markdown
Member Author

@richardlau it keeps failing, and I haven't found any insights in the logs. Do you have any idea?

nodejs-github-bot commented Jun 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44827/

richardlau commented Jun 23, 2022

Copy link
Copy Markdown
Member

@richardlau it keeps failing, and I haven't found any insights in the logs. Do you have any idea?

Hmm I've not seen this before -- the PR rebasing onto the base branch (main) somehow isn't working 😞. I'm not sure why.

This was referenced Jun 24, 2022
Open
Open
Open
Open

RafaelGSS commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

Recreating from scratch.

RafaelGSS closed this Jun 27, 2022

RafaelGSS commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

#43589

github-actions Bot mentioned this pull request Jun 28, 2022
Open
32 tasks
RafaelGSS mentioned this pull request Jun 28, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL