net: fix net keepalive and noDelay - #43561
Merged
nodejs-github-bot merged 1 commit intoJun 29, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
theanarkh
force-pushed
the
fix_tcp_keepalive
branch
from
9c1a62f to
4bbf5ea
Compare
June 24, 2022 19:02
mscdex
reviewed
Jun 24, 2022
Comment thread
test/parallel/test-net-server-keepalive.js
Outdated
mscdex
reviewed
Jun 24, 2022
Comment thread
test/parallel/test-net-server-nodelay.js
Outdated
theanarkh
force-pushed
the
fix_tcp_keepalive
branch
from
4bbf5ea to
19506bb
Compare
June 25, 2022 03:42
lpinca
approved these changes
Jun 25, 2022
Comment thread
test/parallel/test-net-server-keepalive.js
Outdated
theanarkh
force-pushed
the
fix_tcp_keepalive
branch
from
19506bb to
d262b5c
Compare
June 25, 2022 19:21
1. support setKeepAlive again 2. set keepalive and nodelay to socket which is created by server
theanarkh
force-pushed
the
fix_tcp_keepalive
branch
from
d262b5c to
474849d
Compare
June 26, 2022 02:36
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
33 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jun 27, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
32 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
23 tasks
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
1. support setKeepAlive again 2. set keepalive and nodelay to socket which is created by server PR-URL: #43561 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
1. support setKeepAlive again 2. set keepalive and nodelay to socket which is created by server PR-URL: #43561 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
1. support setKeepAlive again 2. set keepalive and nodelay to socket which is created by server PR-URL: #43561 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
1. support setKeepAlive again 2. set keepalive and nodelay to socket which is created by server PR-URL: nodejs/node#43561 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected subsystem: net