FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use Object for `tests` variable in fs trace test by F3n67u · Pull Request #43585 · nodejs/node · GitHub

/ node Public

test: use Object for tests variable in fs trace test - #43585

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
F3n67u:optimize-test
Jul 9, 2022
ConversationCommits (2)ChecksFiles changed
Merged

test: use Object for tests variable in fs trace test#43585
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
F3n67u:optimize-test

Conversation

F3n67u commented Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 27, 2022
F3n67u marked this pull request as ready for review June 27, 2022 05:36
lpinca added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 27, 2022

github-actions Bot commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2022

This comment was marked as outdated.

Sign in to view
aduh95 approved these changes Jun 27, 2022
View reviewed changes
Comment thread test/parallel/test-trace-events-fs-sync.js Outdated
Update test/parallel/test-trace-events-fs-sync.js
dfac3a2 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

F3n67u commented Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

cross-compiler-rhel8-armv7-gcc-8-glibc-2.28 failed: No space left on device. I filed a issue for this problem: nodejs/build#2977

LiviaMedeiros added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 27, 2022
F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2022

nodejs-github-bot commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44918/

This was referenced Jun 28, 2022
Open
Open
F3n67u mentioned this pull request Jun 29, 2022
Closed
aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Jun 30, 2022

nodejs-github-bot commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44992/

github-actions Bot mentioned this pull request Jul 4, 2022
Open
23 tasks

nodejs-github-bot commented Jul 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45076/

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022

nodejs-github-bot commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45116/

github-actions Bot mentioned this pull request Jul 8, 2022
Open
16 tasks

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45161/

github-actions Bot mentioned this pull request Jul 9, 2022
Open
21 tasks
aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 9, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2022
nodejs-github-bot merged commit 138704f into nodejs:main Jul 9, 2022

nodejs-github-bot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

Landed in 138704f

F3n67u deleted the optimize-test branch July 9, 2022 12:14
targos pushed a commit that referenced this pull request Jul 12, 2022
test: use Object for tests variable in fs trace test
c4d88b3 
PR-URL: #43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
test: use Object for tests variable in fs trace test
def932e 
PR-URL: #43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
test: use Object for tests variable in fs trace test
11df17c 
PR-URL: #43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
test: use Object for tests variable in fs trace test
3aafaae 
PR-URL: nodejs/node#43585
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
aduh95 aduh95 approved these changes
juanarbol juanarbol approved these changes
LiviaMedeiros LiviaMedeiros approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL