doc: fix icu-small example - #43591
Conversation
Sorry, something went wrong.
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
@srl295 does this make sense to you? I suspect at one point it printed M01 but currently it seems to default to using the english value instead of the code when the data is not available. |
Sorry, something went wrong.
srl295
left a comment
There was a problem hiding this comment.
This has been true all the way back to v0.12.18!
Sorry, something went wrong.
|
I think this was probably true for an interim version where the manifest (list of installed locales) wasn't updated properly. But yes , it should resolve to your user's default (such as en-US). > spanish.resolvedOptions();
{ locale: 'en-US',
numberingSystem: 'latn',
calendar: 'gregory',
timeZone: 'America/Chicago',
month: 'long' } |
Sorry, something went wrong.
|
OK stop press. issue… |
Sorry, something went wrong.
$ env LANG=es_US node -p 'new Intl.DateTimeFormat("es", { month: "long" }).format(new Date(9e8));'
M01
$ env LANG=en_US node -p 'new Intl.DateTimeFormat("es", { month: "long" }).format(new Date(9e8));'
January🤦 user environment sensitive tests… |
Sorry, something went wrong.
|
fyi @nodejs/i18n-api |
Sorry, something went wrong.
Co-authored-by: Steven R. Loomis <srl295@gmail.com>
|
@srl295 thanks for catching that its dependent on the default locale. That may help resolve the original question I had which led me to look at this doc/find the difference. |
Sorry, something went wrong.
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43591 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43591 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43591 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43591 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Running the same in the icu doc shows that for icu-small the output is January instead of M01. Update the example in the doc to match. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#43591 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Running the same in the icu doc shows that for
icu-small the output is January instead of M01. Update
the example in the doc to match.
Signed-off-by: Michael Dawson mdawson@devrus.com