benchmark: fix fork detection - #43601
Closed
ShogunPanda wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
Sorry, something went wrong.
aduh95
approved these changes
Jun 28, 2022
mcollina
approved these changes
Jun 29, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
ShogunPanda
added a commit
that referenced
this pull request
Jun 29, 2022
PR-URL: #43601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Copy link
Copy Markdown
Member
|
This patch makes benchmark/compare.js not work as expected as it outputs malformed csv data. Expected examples: $ node benchmark/compare.js --new ./node --old ./node --filter ok assert "binary","filename","configuration","rate","time" "old","assert/ok.js","n=100000",38415366.14645858,0.002603125 "new","assert/ok.js","n=100000",36958903.17802217,0.002705708 Outputs with this patch: $ node benchmark/compare.js --new ./node --old ./node --filter ok assert "binary","filename","configuration","rate","time" assert/ok.js n=100000: 40,438,760.551989086 assert/ok.js n=100000: 40,999,014.79367451 assert/ok.js n=100000: 36,593,175.372792974 assert/ok.js n=100000: 37,697,312.44550382 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43598