FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add single executable application initiative by mhdawson · Pull Request #43611 · nodejs/node · GitHub

/ node Public

doc: add single executable application initiative - #43611

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mhdawson:single-exe-initiative
Jul 3, 2022
Merged

doc: add single executable application initiative#43611
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mhdawson:single-exe-initiative

Conversation

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2022

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM
cc @jesec

Should we also reference https://github.com/nodejs/node/issues/43432 in the description because that's the tracking issue for the SEA initiative?

mhdawson force-pushed the single-exe-initiative branch from 9a8e793 to d8c069c Compare June 30, 2022 13:37

Copy link
Copy Markdown
Member Author

@RaisinTen

Should we also reference nodejs/single-executable#75 in the description because that's the tracking issue for the SEA initiative?

Done

jesec commented Jun 30, 2022

Copy link
Copy Markdown
Member

LGTM! 👍

@mhdawson Thanks.

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 3, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 3, 2022
nodejs-github-bot merged commit 2de8dd1 into nodejs:main Jul 3, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2de8dd1

targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: https://github.com/nodejs/node/issues/43432
Refs: #42334
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/technical-priorities.md#single-executable-applications

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #43611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
Refs: https://github.com/nodejs/node/issues/43432
Refs: #42334
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/technical-priorities.md#single-executable-applications

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #43611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: https://github.com/nodejs/node/issues/43432
Refs: #42334
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/technical-priorities.md#single-executable-applications

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #43611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: https://github.com/nodejs/node/issues/43432
Refs: nodejs/node#42334
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/technical-priorities.md#single-executable-applications

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs/node#43611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL