FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cluster, net: fix listen pipe with readable and writable in cluster by theanarkh · Pull Request #43634 · nodejs/node · GitHub

/ node Public

cluster, net: fix listen pipe with readable and writable in cluster - #43634

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_pipe_read_write_in_cluster
Jul 10, 2022
ConversationCommits (1)ChecksFiles changed
Merged

cluster, net: fix listen pipe with readable and writable in cluster#43634
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_pipe_read_write_in_cluster

Conversation

theanarkh commented Jun 30, 2022 •
edited by VoltrexKeyva
Loading

Copy link
Copy Markdown
Contributor

fix listen pipe with readable and writable in cluster.

The bug can be triggered by code as follow.

const cluster = require('cluster');
const net = require('net');
const { unlinkSync } = require('fs');

if (cluster.isPrimary) {
    cluster.fork();
} else {
    try {
        unlinkSync('test.sock');
    } catch(e) {}
    net.createServer(() => {}).listen({
        path: 'test.sock',
        readableAll: true,
        writableAll: true,
    });
}

The permissions of test.sock is srwxr-xr-x instead of srwxrwxrwx .

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected subsystem: cluster, net

nodejs-github-bot commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jun 30, 2022
theanarkh force-pushed the fix_pipe_read_write_in_cluster branch from 807b763 to 09ab407 Compare July 1, 2022 00:09
ShogunPanda requested changes Jul 1, 2022
View reviewed changes

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You should also update the API docs.
The rest looks fine to me!

theanarkh commented Jul 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

You should also update the API docs. The rest looks fine to me!

I think it has been described in the docs before ?

readableAll: For IPC servers makes the pipe readable for all users. Default: false
writableAll: For IPC servers makes the pipe writable for all users. Default: false.

And i think it is a bug, not feature.

theanarkh requested a review from ShogunPanda July 1, 2022 04:46

ShogunPanda commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

Sorry, I missed those somehow.
Approved, LGTM!

mcollina approved these changes Jul 1, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45020/

github-actions Bot mentioned this pull request Jul 4, 2022
Open
23 tasks
theanarkh force-pushed the fix_pipe_read_write_in_cluster branch from 09ab407 to 14588b3 Compare July 4, 2022 23:14

theanarkh commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

@mcollina @ShogunPanda @lpinca Hi, can you help trigger CI ? Thanks !

ShogunPanda commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

@theanarkh The CI is currently locked down due to upcoming security release.
You will have to wait couple of days!

theanarkh commented Jul 8, 2022

Copy link
Copy Markdown
Contributor Author

@theanarkh The CI is currently locked down due to upcoming security release. You will have to wait couple of days!

Thanks! can you help trigger CI ?

ShogunPanda commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Done sir!

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45179/

github-actions Bot mentioned this pull request Jul 9, 2022
Open
21 tasks

nodejs-github-bot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45207/

github-actions Bot mentioned this pull request Jul 10, 2022
Open
20 tasks

theanarkh commented Jul 10, 2022

Copy link
Copy Markdown
Contributor Author

@aduh95 Hi, can you help merge this PR ? Thanks !

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 10, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 10, 2022
nodejs-github-bot merged commit a933a75 into nodejs:main Jul 10, 2022

nodejs-github-bot commented Jul 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in a933a75

targos pushed a commit that referenced this pull request Jul 12, 2022
cluster, net: fix listen pipe with readable and writable in cluster
fa5c464 
PR-URL: #43634
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Jul 12, 2022
Merged
F3n67u mentioned this pull request Jul 12, 2022
Closed
targos pushed a commit that referenced this pull request Jul 20, 2022
cluster, net: fix listen pipe with readable and writable in cluster
6e4796f 
PR-URL: #43634
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
cluster, net: fix listen pipe with readable and writable in cluster
c8706f3 
PR-URL: #43634
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
cluster, net: fix listen pipe with readable and writable in cluster
c83a8df 
PR-URL: nodejs/node#43634
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca left review comments
mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL