FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix default of duplex.allowHalfOpen by vweevers · Pull Request #43665 · nodejs/node · GitHub

/ node Public

doc: fix default of duplex.allowHalfOpen - #43665

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vweevers:doc-allowhalfopen
Jul 5, 2022
Merged

doc: fix default of duplex.allowHalfOpen#43665
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vweevers:doc-allowhalfopen

Conversation

vweevers commented Jul 3, 2022

Copy link
Copy Markdown
Contributor

To match the default value of allowHalfOpen in new stream.Duplex(options).

nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 3, 2022
lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 4, 2022

github-actions Bot commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2022
nodejs-github-bot merged commit 029215d into nodejs:main Jul 5, 2022

Copy link
Copy Markdown
Collaborator

Landed in 029215d

vweevers deleted the doc-allowhalfopen branch July 5, 2022 18:50
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43665
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43665
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43665
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43665
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL