FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improved readability by 0xSanyam · Pull Request #43694 · nodejs/node · GitHub

/ node Public

doc: improved readability - #43694

Merged
aduh95 merged 6 commits into
nodejs:mainfrom
0xSanyam:main
Jul 6, 2022
ConversationCommits (6)ChecksFiles changed
Merged

doc: improved readability#43694
aduh95 merged 6 commits into
nodejs:mainfrom
0xSanyam:main

Conversation

0xSanyam commented Jul 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixed some grammar

nodejs-github-bot commented Jul 5, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Jul 5, 2022

richardlau commented Jul 5, 2022

Copy link
Copy Markdown
Member

We lint for "hostname" as a prohibited string in favour of "host name": https://github.com/nodejs/remark-preset-lint-node/blob/c0d7ffbaeaa686208dd4a7865bcc1ea07dc33fca/index.js#L93

0xSanyam commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

@richardlau understood, I'll correct it

mcollina approved these changes Jul 5, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

0xSanyam changed the title Improved readability doc: improved readability Jul 5, 2022
benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 5, 2022

github-actions Bot commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

benjamingr commented Jul 6, 2022

Copy link
Copy Markdown
Member

Any chance you can change the commit message to adhere to the guidelines changing doc to docs in the title and to squash the commits :)?

0xSanyam commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

@benjamingr to be clear, I'll have to change the title to 'docs: improved readability' and the commit message to same as well?

0xSanyam commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

I'm closing this PR for now, will come with a fix

0xSanyam closed this Jul 6, 2022
0xSanyam mentioned this pull request Jul 6, 2022
Closed
aduh95 reopened this Jul 6, 2022
aduh95 merged commit 9512da0 into nodejs:main Jul 6, 2022

aduh95 commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Landed in 9512da0
Thanks for the contribution 🎉

0xSanyam commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Great! Thank you

targos pushed a commit that referenced this pull request Jul 12, 2022
doc: improve readability of dns.md
d46261c 
PR-URL: #43694
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
doc: improve readability of dns.md
b63b65c 
PR-URL: #43694
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
doc: improve readability of dns.md
c941798 
PR-URL: #43694
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
doc: improve readability of dns.md
18ec135 
PR-URL: nodejs/node#43694
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
HarshithaKP HarshithaKP approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL