FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

wasi: fast calls by devsnek · Pull Request #43697 · nodejs/node · GitHub

/ node Public

wasi: fast calls - #43697

Merged
nodejs-github-bot merged 1 commit into
mainfrom
wasi-fast-calls
Dec 8, 2022
ConversationCommits (1)ChecksFiles changed
Merged

wasi: fast calls#43697
nodejs-github-bot merged 1 commit into
mainfrom
wasi-fast-calls

Conversation

devsnek commented Jul 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

implement fast calls for the wasi module.

the individual calls are about 50-100% faster, and testing with ripgrep compiled to wasm, it looks like real world programs are about 15-20% faster.

nodejs-github-bot commented Jul 5, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/v8-update
  • @nodejs/wasi

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 5, 2022
devsnek force-pushed the wasi-fast-calls branch 5 times, most recently from 922d211 to b3f59cf Compare July 5, 2022 23:36
devsnek added v8 engine Issues and PRs related to the V8 dependency. wasm Issues and PRs related to WebAssembly. v8 module Issues and PRs related to the "v8" subsystem. wasi Issues and PRs related to the WebAssembly System Interface. labels Jul 5, 2022
devsnek force-pushed the wasi-fast-calls branch from b3f59cf to d49c0ba Compare July 5, 2022 23:41

devsnek commented Jul 6, 2022

Copy link
Copy Markdown
Member Author

some hacky microbenchmarks i have say that this makes wasi calls ~2x faster. next i need to find some "real world" programs and see how those perform...

devsnek force-pushed the wasi-fast-calls branch 2 times, most recently from fb6e1e4 to 0bf8869 Compare July 7, 2022 04:53
bnoordhuis reviewed Jul 7, 2022
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Drive-by comment.

Comment thread src/node_wasi.cc Outdated

nodejs-github-bot commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45122/

devsnek force-pushed the wasi-fast-calls branch from 0bf8869 to 08d56e8 Compare July 8, 2022 06:22
devsnek marked this pull request as ready for review July 8, 2022 06:22
devsnek force-pushed the wasi-fast-calls branch from 08d56e8 to 676c0b3 Compare July 8, 2022 08:49

targos commented Jul 8, 2022

Copy link
Copy Markdown
Member

Please increment the embedder string in common.gypi once in each V8 backport commit.

devsnek force-pushed the wasi-fast-calls branch from 676c0b3 to 23e29ee Compare July 8, 2022 08:53
github-actions Bot mentioned this pull request Jul 9, 2022
Open
21 tasks
devsnek force-pushed the wasi-fast-calls branch from 23e29ee to 3669a0f Compare July 9, 2022 06:00

nodejs-github-bot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45196/

github-actions Bot mentioned this pull request Dec 8, 2022
Open
8 tasks
devsnek added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 8, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2022
nodejs-github-bot merged commit b3bf07e into main Dec 8, 2022
nodejs-github-bot deleted the wasi-fast-calls branch December 8, 2022 04:22

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

Landed in b3bf07e

github-actions Bot mentioned this pull request Dec 9, 2022
Open
5 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
wasi: fast calls
1aa4a6b 
PR-URL: #43697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Dec 12, 2022
Merged

targos commented Dec 13, 2022

Copy link
Copy Markdown
Member

I tried to include this in v19.3.0 but two wasi tests failed on ARM macs.

targos pushed a commit that referenced this pull request Dec 14, 2022
wasi: fast calls
476670e 
PR-URL: #43697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

devsnek commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

@targos if you want to try, you should be able to backport this to 19 if you include v8/v8@bf0bd48

targos pushed a commit to targos/node that referenced this pull request Dec 19, 2022
wasi: fast calls
3e67704 
PR-URL: nodejs#43697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Dec 28, 2022
wasi: fast calls
7bd6a2c 
PR-URL: #43697
Backport-PR-URL: #45908
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2023
Merged

juanarbol commented Jan 26, 2023

Copy link
Copy Markdown
Member

This is not landing cleanly in v18.x release line

TerrorJack mentioned this pull request Feb 22, 2023
Closed
kateinoigakukun mentioned this pull request Jan 4, 2024
Closed
TerrorJack mentioned this pull request May 21, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis left review comments
cjihrig cjihrig approved these changes
addaleax Awaiting requested review from addaleax
guybedford Awaiting requested review from guybedford
targos Awaiting requested review from targos

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface. wasm Issues and PRs related to WebAssembly.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL