FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add details for July 2022 security releases by BethGriggs · Pull Request #43733 · nodejs/node · GitHub

/ node Public

doc: add details for July 2022 security releases - #43733

Closed
BethGriggs wants to merge 4 commits into
nodejs:mainfrom
BethGriggs:details
ConversationCommits (4)ChecksFiles changed
Closed

doc: add details for July 2022 security releases#43733
BethGriggs wants to merge 4 commits into
nodejs:mainfrom
BethGriggs:details

Conversation

BethGriggs commented Jul 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member
  • copy as appropriate to Node.js 16/14 changelogs once content has been reviewed
    • I'll open a separate PR for Node.js 16 and 14 as they do not have the --openssl-shared-config flag.
  • update nodejs.org blog posts

I think providing the additional information in the changelogs would be useful (even if retroactive). Also, indicate the breaking changes as such.

cc: @RafaelGSS (I'll also add as co-author as a lot of this is copying your text.)

BethGriggs added the wip Issues and PRs that are still a work in progress. label Jul 8, 2022
nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Jul 8, 2022
RafaelGSS approved these changes Jul 8, 2022
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I would also mention the https://nodejs.org/en/blog/vulnerability/july-2022-security-releases/ post since it contains more detailed information and missing pieces in the changelog such as: "Attempt to read openssl.cnf from /home/iojs/build/ upon startup" and "DNS rebinding in --inspect via invalid IP addresses"

addaleax reviewed Jul 8, 2022
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V18.md Outdated
Comment thread doc/changelogs/CHANGELOG_V18.md Outdated
Comment thread doc/changelogs/CHANGELOG_V18.md Outdated
Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

BethGriggs commented Jul 8, 2022

Copy link
Copy Markdown
Member Author

@addaleax, thank you for the suggestions. Sorry! I was working on some edits at the same time. I'll manually review all of your suggestions and apply

doc: add details for July 2022 security releases
14ce103 
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
BethGriggs removed the wip Issues and PRs that are still a work in progress. label Jul 8, 2022
BethGriggs marked this pull request as ready for review July 8, 2022 16:24
mhdawson reviewed Jul 8, 2022
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V18.md Outdated
mhdawson reviewed Jul 8, 2022
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V18.md
mhdawson reviewed Jul 8, 2022
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BethGriggs added a commit that referenced this pull request Jul 11, 2022
doc: add details for July 2022 security releases
15bb82b 
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #43733
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>

BethGriggs commented Jul 11, 2022

Copy link
Copy Markdown
Member Author

Landed in 15bb82b

BethGriggs closed this Jul 11, 2022
BethGriggs deleted the details branch July 11, 2022 17:00
targos pushed a commit that referenced this pull request Jul 12, 2022
doc: add details for July 2022 security releases
4569d6e 
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #43733
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Jul 12, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RafaelGSS RafaelGSS approved these changes
addaleax addaleax approved these changes
richardlau richardlau approved these changes
+1 more reviewer
mhdawson mhdawson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL