doc: remove openssl 1.x reference - #43734
Merged
nodejs-github-bot merged 1 commit intoJul 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
Sorry, something went wrong.
richardlau
approved these changes
Jul 8, 2022
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
There's a bullet point at the beginning of this doc referring to Node.js 12 that should also go, but that could be done separately.
Sorry, something went wrong.
richardlau
reviewed
Jul 8, 2022
Comment thread
doc/contributing/maintaining-openssl.md
Outdated
RafaelGSS
force-pushed
the
maintaining-openssl-3-update
branch
from
f03862e to
00cc428
Compare
July 8, 2022 14:49
richardlau
approved these changes
Jul 8, 2022
aduh95
reviewed
Jul 8, 2022
Comment thread
doc/contributing/maintaining-openssl.md
Outdated
lpinca
approved these changes
Jul 8, 2022
tniessen
approved these changes
Jul 8, 2022
RafaelGSS
force-pushed
the
maintaining-openssl-3-update
branch
from
00cc428 to
538f238
Compare
July 8, 2022 17:53
aduh95
approved these changes
Jul 8, 2022
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Jul 9, 2022
RaisinTen
approved these changes
Jul 10, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43734 ✔ Done loading data for nodejs/node/pull/43734 ----------------------------------- PR info ------------------------------------ Title doc: remove openssl 1.x reference (#43734) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:maintaining-openssl-3-update -> nodejs:main Labels doc, fast-track, dont-land-on-v14.x, dont-land-on-v16.x Commits 1 - doc: remove openssl 1.x reference Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/43734 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43734 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 Jul 2022 14:42:57 GMT ✔ Approvals: 5 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033024170 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033067101 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033118885 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033391893 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43734#pullrequestreview-1033641795 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2646357011 |
Sorry, something went wrong.
mcollina
approved these changes
Jul 11, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
Refs: #43734 (review) PR-URL: #43744 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43734 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Refs: #43734 (review) PR-URL: #43744 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 1.x is only used in v16 and v14. To avoid confusions I recommend removing OpenSSL 1.x references from main and v18.x.
Note: these references will still exist in v16.x and v14.x branches