test: fix typo in file name - #43764
Merged
aduh95 merged 1 commit intoJul 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
`desctibe` -> `describe`
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Sorry, something went wrong.
MoLow
reviewed
Jul 10, 2022
MoLow
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
whoops :) thanks for fixing
Sorry, something went wrong.
F3n67u
approved these changes
Jul 11, 2022
Trott
approved these changes
Jul 11, 2022
cjihrig
approved these changes
Jul 11, 2022
RaisinTen
approved these changes
Jul 11, 2022
marsonya
approved these changes
Jul 11, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43764 ✔ Done loading data for nodejs/node/pull/43764 ----------------------------------- PR info ------------------------------------ Title test: fix typo in file name (#43764) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-typo-test-runner -> nodejs:main Labels test, fast-track, author ready, test_runner Commits 1 - test: fix typo in file name Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/43764 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen Reviewed-By: Akhil Marsonya ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43764 Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen Reviewed-By: Akhil Marsonya -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 10 Jul 2022 20:43:19 GMT ✔ Approvals: 4 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033710605 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033720542 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033783728 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033830849 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2647593136 |
Sorry, something went wrong.
lpinca
approved these changes
Jul 11, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
`desctibe` -> `describe` PR-URL: #43764 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
`desctibe` -> `describe` PR-URL: #43764 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
`desctibe` -> `describe` PR-URL: nodejs/node#43764 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
desctibe -> describe