build: make GitPod less noisy - #43823
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
richardlau
approved these changes
Jul 13, 2022
tniessen
approved these changes
Jul 13, 2022
Disable prebuilds for pull requests. addComment now defaults to false so we don't need to set it anymore. Refs: nodejs#43789 (comment) Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration
Copy link
Copy Markdown
Member
Author
|
Well, that rebase-and-force-push did not go the way I expected.... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Fixed it, but it won't let me re-open. sigh.... |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable prebuilds for pull requests.
addComment now defaults to false so we don't need to set it anymore.
Refs: #43789 (comment)
Refs: https://www.gitpod.io/docs/prebuilds#github-specific-configuration