FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use platformTimeout() in more places by mscdex · Pull Request #4387 · nodejs/node · GitHub

/ node Public

test: use platformTimeout() in more places - #4387

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:fix-arm-test-timeouts
Closed

test: use platformTimeout() in more places#4387
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:fix-arm-test-timeouts

Conversation

mscdex commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

Without these changes, the pi1-raspbian-wheezy CI node was timing out on these tests.

Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.
mscdex added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM architecture. http Issues or PRs related to the http subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. labels Dec 22, 2015

Copy link
Copy Markdown
Member

LGTM

1 similar comment

cjihrig commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

LGTM

mscdex added a commit that referenced this pull request Dec 22, 2015
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: #4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

mscdex commented Dec 22, 2015

Copy link
Copy Markdown
Contributor Author

Landed in d847a74.

mscdex closed this Dec 22, 2015
mscdex deleted the fix-arm-test-timeouts branch December 22, 2015 20:07
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: nodejs#4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mscdex added a commit that referenced this pull request Jan 7, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: #4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: #4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: nodejs#4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arm Issues and PRs related to the ARM architecture. dgram Issues and PRs related to the dgram subsystem / UDP. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL