FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark sequential/test-gc-http-client-onerror as flaky by mcollina · Pull Request #43957 · nodejs/node · GitHub

/ node Public

test: mark sequential/test-gc-http-client-onerror as flaky - #43957

Closed
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:mark-test-as-flaky
ConversationCommits (1)ChecksFiles changed
Closed

test: mark sequential/test-gc-http-client-onerror as flaky#43957
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:mark-test-as-flaky

Conversation

mcollina commented Jul 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Matteo Collina hello@matteocollina.com

Ref: nodejs/reliability#329

test: mark sequential/test-gc-http-client-onerror as flaky
43bd583 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina requested review from ShogunPanda and tniessen July 23, 2022 12:30
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 23, 2022
mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Jul 23, 2022
tniessen mentioned this pull request Jul 23, 2022
Closed
tniessen approved these changes Jul 23, 2022
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think sequential/test-gc-http-client is also flaky (just like sequential/test-gc-http-client-timeout).

mcollina commented Jul 23, 2022

Copy link
Copy Markdown
Member Author

Definitely. sequential/test-gc-http-client failed 7 times yesterday like this one.

I opened a PR at a time as it seems how it was done other times, but I'm also ok in massively adding all of them in one.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022

nodejs-github-bot commented Jul 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45613/

lpinca commented Jul 23, 2022

Copy link
Copy Markdown
Member

It looks like the issue will be fixed by #43949.

github-actions Bot mentioned this pull request Jul 24, 2022
Open
17 tasks
lpinca mentioned this pull request Jul 24, 2022
Closed

F3n67u commented Jul 24, 2022

Copy link
Copy Markdown
Contributor

FYI, #43949 has merged to main branch and fixed test-gc-http-client-onerror test. So this pr could be closed.

mcollina closed this Jul 24, 2022
This was referenced Jul 25, 2022
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
ShogunPanda Awaiting requested review from ShogunPanda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL