FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove usages of GetBackingStore in node-api by kvakil · Pull Request #44075 · nodejs/node · GitHub

/ node Public

src: remove usages of GetBackingStore in node-api - #44075

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kvakil:nodeapi-backingstores
Aug 3, 2022
ConversationCommits (1)ChecksFiles changed
Merged

src: remove usages of GetBackingStore in node-api#44075
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kvakil:nodeapi-backingstores

Conversation

kvakil commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

This removes all usages of GetBackingStore in node-api. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921

src: remove usages of GetBackingStore in node-api
769d815 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: nodejs#32226
Refs: nodejs#43921

nodejs-github-bot commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 1, 2022
kvakil mentioned this pull request Aug 1, 2022
Merged
F3n67u added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 1, 2022
mcollina approved these changes Aug 1, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

RaisinTen commented Aug 1, 2022

Copy link
Copy Markdown
Member

@F3n67u a Jenkins CI run is required for this PR to be marked as author ready PRs that have at least one approval, no outstanding review comments, and a CI started. (the needs-ci PRs that need a full CI run. label denotes that). I'm starting one for this PR, could you take care of the other ones where you applied the label? Thanks!

nodejs-github-bot commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45761/

F3n67u commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@F3n67u a Jenkins CI run is required for this PR to be marked as author ready PRs that have at least one approval, no pending requests for changes, and a CI started. (the needs-ci PRs that need a full CI run. label denotes that). I'm starting one for this PR, could you take care of the other ones where you applied the label? Thanks!

Done. Thanks for your friendly reminder.

kvakil removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 1, 2022

kvakil commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

(Jenkins seems to have flaked with java.nio.channels.ClosedChannelException. I'm retrying the build.)

kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2022

nodejs-github-bot commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45776/

github-actions Bot mentioned this pull request Aug 2, 2022
Open
11 tasks
kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022

nodejs-github-bot commented Aug 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45787/

kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2022

nodejs-github-bot commented Aug 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45792/

kvakil added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 2, 2022
kvakil self-assigned this Aug 2, 2022
github-actions Bot mentioned this pull request Aug 3, 2022
Open
15 tasks
kvakil added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 3, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2022
nodejs-github-bot merged commit 4dedd81 into nodejs:main Aug 3, 2022

nodejs-github-bot commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4dedd81

This was referenced Aug 5, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
src: remove usages of GetBackingStore in node-api
8a79636 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921
PR-URL: #44075
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
src: remove usages of GetBackingStore in node-api
8e1b7e2 
This removes all usages of GetBackingStore in `node-api`. See the linked
issue for an explanation.

Refs: #32226
Refs: #43921
PR-URL: #44075
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
ruyadorno mentioned this pull request Aug 23, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
addaleax addaleax approved these changes
gengjiawen gengjiawen approved these changes
legendecas legendecas approved these changes
RaisinTen RaisinTen approved these changes
+1 more reviewer
F3n67u F3n67u approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

kvakil

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL