src: remove usages of GetBackingStore in modules - #44076
Merged
nodejs-github-bot merged 1 commit intoAug 3, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This removes all usages of GetBackingStore in modules. See the linked issue for an explanation. Refs: nodejs#32226 Refs: nodejs#43921
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
RaisinTen
approved these changes
Aug 1, 2022
F3n67u
approved these changes
Aug 1, 2022
mcollina
approved these changes
Aug 1, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
VoltrexKeyva
approved these changes
Aug 1, 2022
addaleax
approved these changes
Aug 1, 2022
santigimeno
approved these changes
Aug 1, 2022
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
This removes all usages of GetBackingStore in modules. See the linked issue for an explanation. Refs: #32226 Refs: #43921 PR-URL: #44076 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
This removes all usages of GetBackingStore in modules. See the linked issue for an explanation. Refs: #32226 Refs: #43921 PR-URL: #44076 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all usages of GetBackingStore in modules. See the linked
issue for an explanation.
Refs: #32226
Refs: #43921