stream: update TextEncoderStream to align with the latest spec - #44101
Merged
nodejs-github-bot merged 3 commits intoAug 4, 2022
Merged
stream: update TextEncoderStream to align with the latest spec#44101nodejs-github-bot merged 3 commits into
nodejs-github-bot merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
reviewed
Aug 2, 2022
Comment thread
lib/internal/webstreams/encoding.js
Outdated
Comment on lines
6
to
7
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| Uint8Array, | |
| String | |
| String, | |
| Uint8Array, |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Done f2304b604d40fab394a3cbc81a04ed1d28dfa4b5
Sorry, something went wrong.
benjamingr
approved these changes
Aug 2, 2022
cola119
force-pushed
the
update-encoder-spec
branch
from
f2304b6 to
03412dc
Compare
August 3, 2022 00:31
aduh95
reviewed
Aug 3, 2022
Comment thread
lib/internal/webstreams/encoding.js
Outdated
cola119
force-pushed
the
update-encoder-spec
branch
from
03412dc to
c44d983
Compare
August 3, 2022 09:15
aduh95
reviewed
Aug 3, 2022
Comment thread
lib/internal/webstreams/encoding.js
aduh95
approved these changes
Aug 3, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Aug 5, 2022
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
PR-URL: #44101 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
PR-URL: #44101 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Member
|
This is causing "wpt" tests in v16.x to fail. I will add the backport layer to this. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updated TextEncoderStream implementation to align with the latest WHATWG spec.
Test cases of /test/fixtures/wpt/encoding/streams/encode-utf8.any.js (WPT for TextEncoderStream) are all passed now. (The previous implementation didn't support surrogate pairs.)