deps: V8: PPC: pass a scratch register when using register_location - #44115
Closed
miladfarca wants to merge 1 commit into
Closed
deps: V8: PPC: pass a scratch register when using register_location#44115miladfarca wants to merge 1 commit into
miladfarca wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
gengjiawen
approved these changes
Aug 3, 2022
Copy link
Copy Markdown
Contributor
Author
|
@richardlau would you please help review and initiate CI tests for this CL? thanks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/45864/ |
Sorry, something went wrong.
richardlau
approved these changes
Aug 5, 2022
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Change LGTM. Commit message should quote the message from the upstream commit, see example in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-V8.md -- can be fixed on landing.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@richardlau Thanks, I've added it to the description. |
Sorry, something went wrong.
mhdawson
approved these changes
Aug 5, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
richardlau
pushed a commit
that referenced
this pull request
Aug 5, 2022
Original commit message:
PPC: pass a scratch reg when using register_location
Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
Reviewed-by: Junliang Yan <junyan@redhat.com>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#82146}
Fixes: #44055
PR-URL: #44115
Refs: v8/v8@9861ce1
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
Original commit message:
PPC: pass a scratch reg when using register_location
Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
Reviewed-by: Junliang Yan <junyan@redhat.com>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#82146}
Fixes: #44055
PR-URL: #44115
Refs: v8/v8@9861ce1
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
Original commit message:
PPC: pass a scratch reg when using register_location
Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
Reviewed-by: Junliang Yan <junyan@redhat.com>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#82146}
Fixes: #44055
PR-URL: #44115
Refs: v8/v8@9861ce1
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
PPC: pass a scratch reg when using register_location
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
Cr-Commit-Position: refs/heads/main@{#82146}
Fixes: #44055
Refs: v8/v8@9861ce1