test: update wpt url status - #44175
Merged
nodejs-github-bot merged 1 commit intoAug 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cola119
marked this pull request as ready for review
August 8, 2022 14:32
targos
approved these changes
Aug 8, 2022
aduh95
approved these changes
Aug 8, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
F3n67u
approved these changes
Aug 8, 2022
lpinca
approved these changes
Aug 8, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44175 ✔ Done loading data for nodejs/node/pull/44175 ----------------------------------- PR info ------------------------------------ Title test: update wpt url status (#44175) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cola119:update-url-status -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: update wpt url status Committers 1 - cola119 PR-URL: https://github.com/nodejs/node/pull/44175 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Feng Yu Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44175 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Feng Yu Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 08 Aug 2022 14:31:25 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065324586 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065342638 ✔ - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065381517 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065631496 ✖ This PR needs to wait 8 more hours to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-08-08T15:11:35Z: https://ci.nodejs.org/job/node-test-pull-request/45924/ - Querying data for job/node-test-pull-request/45924/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2830437356 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
PR-URL: #44175 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
PR-URL: #44175 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Member
|
This causes jstests to fail: Error: Found 1 unexpected failures. Consider updating test/wpt/status/url.json for these files:
urlencoded-parser.any.js
at process.<anonymous> (/home/juanarbol/GitHub/node/test/common/wpt.js:496:15)
at process.emit (node:events:525:35)
Command: out/Release/node /home/juanarbol/GitHub/node/test/wpt/test-url.js |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlencoded-parser.any.js is now passed thanks to nodejs/undici#1563, which is released in undici v5.8.1