test: use --port=0 in debugger tests that do not have to work on 9229 - #44342
test: use --port=0 in debugger tests that do not have to work on 9229#44342joyeecheung wants to merge 1 commit into
Conversation
Sorry, something went wrong.
To avoid failures when there is another running process occupying the port 9229 which may happen if there is a stale process, use the --port argument of node-inspect to use a random port in tests that don't have to work on port 9229. The following tests are not touched: - test-debugger-launch: specifically needs to test port 9229 - test-debugger-pid: needs modifications to node-inspect - test-debugger-random-port-with-inspect-port: same as -pid test
|
The tests here can fail if one runs a node inspect process that listens to 9229 on the background before running them. As far as I can tell though, they don't actually need to be run on 9229, all they need are just a valid node-inspect session, so changing them to run on random ports seem reasonable to me and can help with nodejs/build#3014 which has been failing a lot of windows CI runs lately (see nodejs/reliability#354). test-debugger-pid and test-debugger-random-port-with-inspect-port would need some fixes in node-inspect to run on random ports, as node-inspect still waits for 9229 to free up when --inspect-port or -p is used, I'll send in another PR for those. |
Sorry, something went wrong.
|
cc @nodejs/testing |
Sorry, something went wrong.
Sorry, something went wrong.
|
hmm, apparently the tests are still timing out, so there must be something else that is causing the timeout |
Sorry, something went wrong.
|
It's too old now. I'll open a new one and move them to parallel. |
Sorry, something went wrong.
To avoid failures when there is another running process occupying
the port 9229 which may happen if there is a stale process, use the
--port argument of node-inspect to use a random port in tests that
don't have to work on port 9229.
The following tests are not touched:
Refs: nodejs/build#3014