FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: upgrade llhttp to 6.0.9 by ShogunPanda · Pull Request #44344 · nodejs/node · GitHub

/ node Public

deps: upgrade llhttp to 6.0.9 - #44344

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShogunPanda:update-llhttp
Aug 25, 2022
ConversationCommits (1)ChecksFiles changed
Merged

deps: upgrade llhttp to 6.0.9#44344
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShogunPanda:update-llhttp

Conversation

ShogunPanda commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

Fixes: #43115

nodejs-github-bot commented Aug 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Aug 22, 2022

nodejs-github-bot commented Aug 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46150/

RafaelGSS approved these changes Aug 22, 2022
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

mcollina approved these changes Aug 22, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 24, 2022
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2022
nodejs-github-bot merged commit ec0d8da into nodejs:main Aug 25, 2022

nodejs-github-bot commented Aug 25, 2022

Copy link
Copy Markdown
Collaborator

Landed in ec0d8da

RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
deps: upgrade llhttp to 6.0.9
1e451dc 
PR-URL: #44344
Fixes: #43115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 5, 2022
Merged
Merged
climba03003 reviewed Sep 9, 2022
View reviewed changes
Comment thread deps/llhttp/CMakeLists.txt
cmake_policy(SET CMP0069 NEW)

project(llhttp VERSION 6.0.5)
project(llhttp VERSION )

climba03003 Sep 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@ShogunPanda
It seems like a missing version here?

ShogunPanda commented Sep 9, 2022

Copy link
Copy Markdown
Contributor Author

Yes, somehow I missed it.

@mhdawson Do you think we can fix this in #44136?

mhdawson commented Sep 9, 2022

Copy link
Copy Markdown
Member

@ShogunPanda do you mean fix the instructions, or update the instrtuction and then fix the missing version number at the same time?

ShogunPanda commented Sep 9, 2022

Copy link
Copy Markdown
Contributor Author

The latter. Fix both the version and the instructions, eventually following my suggestion above.

targos pushed a commit that referenced this pull request Sep 16, 2022
deps: upgrade llhttp to 6.0.9
5be2665 
PR-URL: #44344
Fixes: #43115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

ruyadorno commented Sep 23, 2022

Copy link
Copy Markdown
Member

Heads up @ShogunPanda this commit had landed in v16.x-staging but it ended up conflicting with 0713e21 and had to be skipped when rebasing. I would appreciate if you could follow up and make sure that everything looks fine with regards to llhttp version in the v16.x release line.

ShogunPanda commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

@ruyadorno Since 16.17.1 has been released and it contains 6.0.10, I think this has been superseded. Am I wrong?

ruyadorno commented Sep 23, 2022

Copy link
Copy Markdown
Member

I would assume so but I believe it might need your eyes just to make sure it didn't missed anything from this update I guess.
Anyways, if that's the case and it has been successfully superseded than I believe we should add a label to this PR to avoid having this commit showing up during the update of the staging branch phase. Adding dont-land-on-v16.x should do it 😊

ruyadorno commented Sep 23, 2022

Copy link
Copy Markdown
Member

actually, I'll preemptively add the dont-land label 😁

ShogunPanda commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

So, all files are correctly changed, except for deps/llhttp/llhttp.h and deps/llhttp/CMakeLists.txt which show the wrong version (not the 6.0.9 on this PR but the newly released 6.0.10). What shall we do?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Trott Trott approved these changes
richardlau richardlau approved these changes
trivikr trivikr approved these changes
RafaelGSS RafaelGSS approved these changes
+1 more reviewer
climba03003 climba03003 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http module accepts all http versions (e.g. HTTP/9.9) and treats/responds to them as http1

10 participants

Back | FazBrowse Home | New Git URL