FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: enrich test commands with executable by tony-go · Pull Request #44347 · nodejs/node · GitHub

/ node Public

doc: enrich test commands with executable - #44347

Merged
nodejs-github-bot merged 10 commits into
nodejs:mainfrom
tony-go:run-test-doc
Feb 6, 2023
ConversationCommits (10)ChecksFiles changed
Merged

doc: enrich test commands with executable#44347
nodejs-github-bot merged 10 commits into
nodejs:mainfrom
tony-go:run-test-doc

Conversation

tony-go commented Aug 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Hey 👋

A tiny pull request to enrich test commands in the documentation.

cc @arkerone

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 22, 2022
tony-go commented Aug 22, 2022
View reviewed changes
Comment thread BUILDING.md Outdated
tony-go marked this pull request as ready for review August 23, 2022 15:16
aduh95 reviewed Aug 23, 2022
View reviewed changes
Comment thread BUILDING.md
Comment thread BUILDING.md Outdated
Comment thread BUILDING.md Outdated
Comment thread BUILDING.md Outdated
tony-go requested a review from aduh95 August 24, 2022 06:38
aduh95 reviewed Aug 24, 2022
View reviewed changes
Comment thread BUILDING.md Outdated
RaisinTen reviewed Aug 24, 2022
View reviewed changes
Comment thread BUILDING.md Outdated
Comment thread BUILDING.md Outdated
tony-go requested review from RaisinTen and aduh95 and removed request for RaisinTen and aduh95 August 24, 2022 16:53
RaisinTen approved these changes Aug 25, 2022
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, would be nice if you could also include the reasoning (#44347 (comment)) in the description

RaisinTen reviewed Aug 26, 2022
View reviewed changes

RaisinTen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

After #44407 lands, tools/test.py should work without explicitly writing out the command name. Calling it like python ... would only be required on Windows.

himself65 mentioned this pull request Sep 6, 2022
Merged
tony-go requested a review from aduh95 September 7, 2022 05:24

tony-go commented Feb 4, 2023

Copy link
Copy Markdown
Member Author

@RaisinTen I finally updated the doc, could PTAL ^^

tony-go requested review from RaisinTen and removed request for aduh95 February 4, 2023 11:36
richardlau reviewed Feb 4, 2023
View reviewed changes
Comment thread BUILDING.md Outdated
tony-go requested review from richardlau and removed request for RaisinTen February 5, 2023 15:32

tony-go commented Feb 5, 2023

Copy link
Copy Markdown
Member Author

Finally, remove the python exec from examples and add a note for windows.

RaisinTen approved these changes Feb 6, 2023
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 6, 2023
RaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 6, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2023
nodejs-github-bot merged commit 2dacd07 into nodejs:main Feb 6, 2023

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2dacd07

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
doc: enrich test command with executable
a7beac0 
PR-URL: #44347
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
doc: enrich test command with executable
f1de3f7 
PR-URL: #44347
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
jasnell jasnell approved these changes
richardlau richardlau approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL