FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: codify findSourceMap return value when not found by legendecas · Pull Request #44397 · nodejs/node · GitHub

/ node Public

lib: codify findSourceMap return value when not found - #44397

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:issue-44391
Aug 27, 2022
Merged

lib: codify findSourceMap return value when not found#44397
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:issue-44391

Conversation

Copy link
Copy Markdown
Member

Return undefined when no source map is found for the given filename on
findSourceMap.

Fixes: #44391

Return `undefined` when no source map is found for the given filename on
`findSourceMap`.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 25, 2022
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2022

Copy link
Copy Markdown
Collaborator

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 27, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2022
nodejs-github-bot merged commit 72df448 into nodejs:main Aug 27, 2022

Copy link
Copy Markdown
Collaborator

Landed in 72df448

legendecas deleted the issue-44391 branch August 28, 2022 06:45
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
Return `undefined` when no source map is found for the given filename on
`findSourceMap`.

PR-URL: #44397
Fixes: #44391
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Copy link
Copy Markdown
Member

Depends on #43875

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js 18.8.0 changed return type of module.findSourceMap()

5 participants


Back | FazBrowse Home | New Git URL