src: remove v8abbr.h - #44402
Merged
nodejs-github-bot merged 1 commit intoAug 30, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
joyeecheung
approved these changes
Aug 26, 2022
addaleax
approved these changes
Aug 26, 2022
gengjiawen
approved these changes
Aug 26, 2022
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: nodejs#43652
tniessen
force-pushed
the
src-remove-v8abbr
branch
from
40bc0a2 to
78cefeb
Compare
August 26, 2022 10:24
Copy link
Copy Markdown
Member
Author
|
Pacified format-cpp. |
Sorry, something went wrong.
bnoordhuis
approved these changes
Aug 26, 2022
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I had this as a todo so thank you for taking it off my plate, Tobias. :-)
As an aside: I don't think it's always correct to read the second field from ExternalString because that's a cached data pointer (i.e., can be nullptr) but since no one's complained so far...
(The first field points to the Canonical Source of Truth but decoding the pointee is involved.)
Sorry, something went wrong.
This comment was marked as outdated.
This was referenced Aug 27, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Aug 28, 2022
30 tasks
RaisinTen
approved these changes
Aug 29, 2022
27 tasks
This was referenced Aug 31, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: #43652 PR-URL: #44402 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Member
|
Adding dont-land labels because this PR depends on a semver-major change #43652 |
Sorry, something went wrong.
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Sep 7, 2022
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: nodejs#43652 PR-URL: nodejs#44402 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed.
Refs: #43652