FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: remove `abortReason` from `WritableStreamDefaultController` by daeyeon · Pull Request #44540 · nodejs/node · GitHub

/ node Public

stream: remove abortReason from WritableStreamDefaultController - #44540

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
daeyeon:main.remove.todo-220906.Tue.3a7b
Sep 9, 2022
ConversationCommits (1)ChecksFiles changed
Merged

stream: remove abortReason from WritableStreamDefaultController#44540
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
daeyeon:main.remove.todo-220906.Tue.3a7b

Conversation

daeyeon commented Sep 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The abortReason property has been removed from the spec since we can get
the abort reason via writableStreamDefaultController.signal.reason.

[Exposed=*]
interface WritableStreamDefaultController {
  readonly attribute AbortSignal signal;
  undefined error(optional any e);
};

This reflects the change and removes a TODO left as a follow-up of #44327.

Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

stream: remove abortReason from WritableStreamDefaultController
e39a3bc 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Sep 6, 2022

daeyeon commented Sep 6, 2022

Copy link
Copy Markdown
Member Author

/cc @nodejs/whatwg-stream

daeyeon added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 6, 2022
mcollina approved these changes Sep 6, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina approved these changes Sep 7, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2022

nodejs-github-bot commented Sep 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46470/

daeyeon added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 8, 2022
mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2022
nodejs-github-bot merged commit a4b2641 into nodejs:main Sep 9, 2022

nodejs-github-bot commented Sep 9, 2022

Copy link
Copy Markdown
Collaborator

Landed in a4b2641

daeyeon deleted the main.remove.todo-220906.Tue.3a7b branch September 23, 2022 17:06
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
stream: remove abortReason from WritableStreamDefaultController
00185f1 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44540
Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Sep 26, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
stream: remove abortReason from WritableStreamDefaultController
0af6e42 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44540
Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

juanarbol commented Oct 3, 2022

Copy link
Copy Markdown
Member

This seems to break the wpt tests in the v16.x release branch; do you think you could backport this?

daeyeon commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Backporting this is pending now since it depends on #43455, #44234, and #44327. I'd like to check first whether I could use the WPT Runner update on the release line.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL