FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x backport] cli: add `--watch` by MoLow · Pull Request #44571 · nodejs/node · GitHub

/ node Public

[v18.x backport] cli: add --watch - #44571

Closed
MoLow wants to merge 1 commit into
nodejs:v18.x-stagingfrom
MoLow:backport-watch-mode
ConversationCommits (1)ChecksFiles changed
Closed

[v18.x backport] cli: add --watch#44571
MoLow wants to merge 1 commit into
nodejs:v18.x-stagingfrom
MoLow:backport-watch-mode

Conversation

MoLow commented Sep 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

backport of #44366 with a fix for tests to skip --import

nodejs-github-bot commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/modules
  • @nodejs/startup

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x labels Sep 8, 2022
joyeecheung mentioned this pull request Sep 8, 2022
Closed

aduh95 commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

MoLow commented Sep 8, 2022

Copy link
Copy Markdown
Member Author

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

done

MoLow force-pushed the backport-watch-mode branch from 65e2c00 to 3a66d6f Compare September 8, 2022 15:29

MoLow commented Sep 11, 2022

Copy link
Copy Markdown
Member Author

@aduh95 what is the procedure of landing this into v18.x-staging?

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2022

This comment was marked as outdated.

Sign in to view

aduh95 commented Sep 11, 2022

Copy link
Copy Markdown
Contributor

@aduh95 what is the procedure of landing this into v18.x-staging?

I know the rule for LTS is to leave it to the appropriate team:

node/doc/contributing/collaborator-guide.md

Lines 768 to 769 in 3ec8876

Only members of @nodejs/backporters should land commits onto LTS staging
branches.

As v18.x is not (yet) LTS, the rule might be different, but I would leave it up to @nodejs/releasers to leave them full control over the release process.

nodejs-github-bot commented Sep 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46518/

This was referenced Sep 12, 2022
Open
Open
Open
Open
RafaelGSS reviewed Sep 15, 2022
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@MoLow can you include the metadata to your commit according to item 9 of https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md guideline?

aduh95 commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

can you include the metadata to your commit according to item 9 of https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md guideline?

@RafaelGSS isn't that done by ncu upon landing?

cli: add --watch
3a6c65b 
PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44571
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow force-pushed the backport-watch-mode branch from 3a66d6f to 3a6c65b Compare September 15, 2022 17:07

MoLow commented Sep 15, 2022

Copy link
Copy Markdown
Member Author

@RafaelGSS added metadata and squashed - as discussed in slack

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2022

nodejs-github-bot commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46611/

github-actions Bot mentioned this pull request Sep 16, 2022
Open
23 tasks

nodejs-github-bot commented Sep 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46618/

RafaelGSS approved these changes Sep 16, 2022
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

This was referenced Sep 17, 2022
Open
Open
Open
Open

RafaelGSS commented Sep 23, 2022

Copy link
Copy Markdown
Member

Landed in 4700ee5

RafaelGSS closed this Sep 23, 2022
RafaelGSS pushed a commit that referenced this pull request Sep 23, 2022
cli: add --watch
4700ee5 
PR-URL: #44366
Backport-PR-URL: #44571
Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
RafaelGSS mentioned this pull request Sep 26, 2022
Merged
RafaelGSS reopened this Sep 27, 2022

RafaelGSS commented Sep 27, 2022

Copy link
Copy Markdown
Member

It didn't land cleanly on the proposal branch. Can you please rebase and run the CI again? See #44799 (comment)

MoLow commented Sep 29, 2022

Copy link
Copy Markdown
Member Author

@RafaelGSS the cause was a merge mess up resulting with both test/parallel/test-watch-mode.mjs and test/sequential/test-watch-mode.mjs in nodejs:v18.x-staging when only one should have existed. I will create a new backport PR with all the relevant commits in a single PR

MoLow closed this Sep 29, 2022
MoLow deleted the backport-watch-mode branch September 29, 2022 08:38
MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JungMinu JungMinu approved these changes
aduh95 aduh95 approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL