doc: explain ClientRequest#setTimeout time unit - #4458
Closed
bripkens wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
State a time unit for the timeout parameter in ClientRequest#setTimeout
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Dec 30, 2015
State a time unit for the timeout parameter in ClientRequest#setTimeout PR-URL: #4458 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Thanks for the contribution @bripkens! I believe this is your first commit to core and I see #4463 is queued up as well, it's great to see you jumping right in. Please holler if you need any help. I hope you continue to find ways to contribute and stick around. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks @rvagg, I'll try to do! :) |
Sorry, something went wrong.
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
State a time unit for the timeout parameter in ClientRequest#setTimeout PR-URL: nodejs#4458 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 13, 2016
State a time unit for the timeout parameter in ClientRequest#setTimeout PR-URL: #4458 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
State a time unit for the timeout parameter in ClientRequest#setTimeout PR-URL: #4458 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
State a time unit for the timeout parameter in ClientRequest#setTimeout PR-URL: nodejs#4458 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State a time unit for the timeout parameter in ClientRequest#setTimeout