FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove `node_bob.h` and `node_bob-inl.h` by RaisinTen · Pull Request #44607 · nodejs/node · GitHub

/ node Public

src: remove node_bob.h and node_bob-inl.h - #44607

Closed
RaisinTen wants to merge 1 commit into
nodejs:mainfrom
RaisinTen:src/remove-node_bob
ConversationCommits (1)ChecksFiles changed
Closed

src: remove node_bob.h and node_bob-inl.h#44607
RaisinTen wants to merge 1 commit into
nodejs:mainfrom
RaisinTen:src/remove-node_bob

Conversation

RaisinTen commented Sep 12, 2022

Copy link
Copy Markdown
Member

These were added in #32379 and were supposed to get removed in #37067.

Signed-off-by: Darshan Sen raisinten@gmail.com

cc @jasnell

src: remove node_bob.h and node_bob-inl.h
e514969 
These were added in nodejs#32379 and were
supposed to get removed in nodejs#37067.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 12, 2022

This comment was marked as outdated.

Sign in to view
RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 12, 2022

tniessen commented Sep 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Just want to make sure this is not going to make James' work more difficult in #44325... cc @jasnell. (There's also a few leftovers in the crypto code base that I have not removed yet because they might still be needed for the upcoming QUIC implementation.)

Looks like these files are required for that PR and would just be re-added. Maybe we should wait with removing more prerequisites of #44325.

github-actions Bot mentioned this pull request Sep 13, 2022
Open
30 tasks

nodejs-github-bot commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46564/

This was referenced Sep 14, 2022
Open
Open
tniessen requested changes Sep 15, 2022
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just making my concern explicit. I don't think we should be removing this while the new QUIC PR depends on these files. It's already a ton of work for James and re-adding files with no changes just seems to add to it.

That's just my take though and I'm only requesting changes so that this point is not missed. If someone believes this should land regardless, I'll gladly dismiss my review.

This was referenced Sep 16, 2022
Open
Open
RaisinTen removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 18, 2022

RaisinTen commented Sep 18, 2022

Copy link
Copy Markdown
Member Author

That was an oversight on my part. I have no intentions of making James' work more difficult, closing. :)

RaisinTen closed this Sep 18, 2022
RaisinTen deleted the src/remove-node_bob branch September 18, 2022 07:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen requested changes
bnoordhuis bnoordhuis approved these changes
addaleax addaleax approved these changes
JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL