FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dns: improve lookup performance by ~3% by anonrig · Pull Request #44629 · nodejs/node · GitHub

/ node Public

dns: improve lookup performance by ~3% - #44629

Closed
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:perf/dns
Closed

dns: improve lookup performance by ~3%#44629
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:perf/dns

Conversation

anonrig commented Sep 13, 2022

Copy link
Copy Markdown
Member

This change improves dns lookup performance by roughly 3%.

Referencing: #44627

                                                              confidence improvement accuracy (*)   (**)   (***)
dns/lookup-promises.js n=5000000 all='false' name='::1'                      -0.03 %       ±2.42% ±3.23%  ±4.22%
dns/lookup-promises.js n=5000000 all='false' name='127.0.0.1'                 0.01 %       ±2.77% ±3.69%  ±4.80%
dns/lookup-promises.js n=5000000 all='true' name='::1'                        0.29 %       ±1.67% ±2.23%  ±2.90%
dns/lookup-promises.js n=5000000 all='true' name='127.0.0.1'                  2.99 %       ±5.73% ±7.70% ±10.16%
dns/lookup.js n=5000000 all='false' name='::1'                                0.37 %       ±0.86% ±1.14%  ±1.49%
dns/lookup.js n=5000000 all='false' name='127.0.0.1'                         -0.21 %       ±0.79% ±1.05%  ±1.37%
dns/lookup.js n=5000000 all='true' name='::1'                                 0.51 %       ±0.93% ±1.24%  ±1.61%
dns/lookup.js n=5000000 all='true' name='127.0.0.1'                          -0.50 %       ±0.89% ±1.18%  ±1.55%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 8 comparisons, you can thus expect the following amount of false-positive results:
  0.40 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.08 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)
`

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Sep 13, 2022

mscdex commented Sep 13, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

I think you're misinterpreting the benchmark comparison output here. You should be looking for repeatable results with *** in the confidence column to ensure that this is indeed an improvement.

Copy link
Copy Markdown

Review requested:

anonrig commented Sep 13, 2022

Copy link
Copy Markdown
Member Author

You're definitely right. I totally missed it. I'm closing the pull request until I find a better improvement. Thanks!

anonrig closed this Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL