FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use async/await in test-debugger-exceptions by pete3249 · Pull Request #44690 · nodejs/node · GitHub

/ node Public

test: use async/await in test-debugger-exceptions - #44690

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pete3249:test-debugger-exceptions
Sep 30, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test: use async/await in test-debugger-exceptions#44690
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pete3249:test-debugger-exceptions

Conversation

pete3249 commented Sep 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes the promises to async/await in test/parallel/test-debugger-exceptions.js.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
Trott added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 16, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2022

nodejs-github-bot commented Sep 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46631/

Trott force-pushed the test-debugger-exceptions branch from af06765 to 700a062 Compare September 23, 2022 23:44
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
Trott reviewed Sep 23, 2022
View reviewed changes
Comment thread test/sequential/test-debugger-exceptions.js Outdated
Trott reviewed Sep 23, 2022
View reviewed changes
Comment thread test/sequential/test-debugger-exceptions.js Outdated
Trott reviewed Sep 23, 2022
View reviewed changes
Comment thread test/sequential/test-debugger-exceptions.js Outdated
Trott removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
Trott reviewed Sep 23, 2022
View reviewed changes
Comment thread test/sequential/test-debugger-exceptions.js Outdated
Trott reviewed Sep 23, 2022
View reviewed changes
Comment thread test/sequential/test-debugger-exceptions.js Outdated
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022

nodejs-github-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46737/

github-actions Bot mentioned this pull request Sep 26, 2022
Open
18 tasks

nodejs-github-bot commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46881/

Trott force-pushed the test-debugger-exceptions branch from ddd830d to 6faf7d3 Compare September 28, 2022 01:45
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022

nodejs-github-bot commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46882/

Trott force-pushed the test-debugger-exceptions branch from 6faf7d3 to 9725a02 Compare September 28, 2022 01:53
Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Sep 28, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022

nodejs-github-bot commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46884/

github-actions Bot mentioned this pull request Sep 29, 2022
Open
16 tasks

nodejs-github-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46921/

nodejs-github-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46941/

Trott commented Sep 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Not sure why the test-worker-prof test is failing on Windows over and over on Jenkins, but I'll try rebasing and force pushing to hope it fixes it.

Trott changed the title src: change promises to async await test: change promises to async await Sep 29, 2022
Trott changed the title test: change promises to async await test: use async/await in test-debugger-exceptions Sep 29, 2022
Trott force-pushed the test-debugger-exceptions branch from 9725a02 to 97d60f9 Compare September 29, 2022 18:45
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022

nodejs-github-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46945/

github-actions Bot mentioned this pull request Sep 30, 2022
Open
17 tasks
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
nodejs-github-bot merged commit bf0c312 into nodejs:main Sep 30, 2022

nodejs-github-bot commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator

Landed in bf0c312

Trott commented Sep 30, 2022

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

This was referenced Oct 1, 2022
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
test: use async/await in test-debugger-exceptions
ee3c6a4 
PR-URL: #44690
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Oct 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL