FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove unused modules by Trott · Pull Request #4475 · nodejs/node · GitHub

/ node Public

test: remove unused modules - #4475

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-unused-modules
ConversationCommits (1)ChecksFiles changed
Closed

test: remove unused modules#4475
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-unused-modules

Conversation

Trott commented Dec 30, 2015

Copy link
Copy Markdown
Member

Many tests use require() to import modules that subsequently never gets
used. This removes those imports and, in a few cases, removes other
unused variables from tests.

I'm especially looking for review on the tests in test/pummel as I'm not 100% clear on how those tests work. It seems like a number of them were failing already prior to these changes (judging from results running make test-pummel on OS X).

Trott added the test Issues and PRs related to the tests. label Dec 30, 2015
bnoordhuis reviewed Dec 30, 2015
View reviewed changes
Comment thread test/parallel/test-cluster-eaddrinuse.js

bnoordhuis Dec 30, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Guess this test is poorly named if it doesn't use the cluster module.

bnoordhuis commented Dec 30, 2015

Copy link
Copy Markdown
Member

LGTM

I'm especially looking for review on the tests in test/pummel as I'm not 100% clear on how those tests work. It seems like a number of them were failing already prior to these changes

I can confirm that.

jasnell commented Dec 30, 2015

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/1115/

test: remove unused modules
6304758 
Many tests use require() to import modules that subsequently never gets
used. This removes those imports and, in a few cases, removes other
unused variables from tests.
Trott force-pushed the rm-unused-modules branch from 831fa73 to 6304758 Compare December 30, 2015 22:42

Trott commented Dec 30, 2015

Copy link
Copy Markdown
Member Author

Rebased and force pushed.

CI: https://ci.nodejs.org/job/node-test-commit/1583/

Trott commented Dec 30, 2015

Copy link
Copy Markdown
Member Author

Seemingly unrelated test failure on one of the Raspberry Pi devices, but CI looks good other than that.

jbergstroem commented Dec 31, 2015

Copy link
Copy Markdown
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jan 2, 2016
test: remove unused modules
6abd8b5 
Many tests use require() to import modules that subsequently never gets
used. This removes those imports and, in a few cases, removes other
unused variables from tests.

PR-URL: nodejs#4475
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

Trott commented Jan 2, 2016

Copy link
Copy Markdown
Member Author

Landed in 6abd8b5

Trott closed this Jan 2, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
test: remove unused modules
06043fd 
Many tests use require() to import modules that subsequently never gets
used. This removes those imports and, in a few cases, removes other
unused variables from tests.

PR-URL: nodejs#4475
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

MylesBorins commented Jan 13, 2016

Copy link
Copy Markdown
Contributor

@Trott this is merging with conflicts on v4.x-staging

would you be able to take a look?

Trott commented Jan 14, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd #4684

MylesBorins mentioned this pull request Mar 10, 2016
Closed
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test: remove unused modules
f096143 
Many tests use require() to import modules that subsequently never gets
used. This removes those imports and, in a few cases, removes other
unused variables from tests.

PR-URL: nodejs#4475
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott deleted the rm-unused-modules branch January 13, 2022 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL