buffer: initialize TextDecoder once for performance - #44787
Merged
nodejs-github-bot merged 1 commit intoOct 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
force-pushed
the
perf/blob
branch
2 times, most recently
from
b37eaa1 to
f31f223
Compare
September 25, 2022 17:03
aduh95
reviewed
Sep 25, 2022
Comment thread
lib/internal/blob.js
Outdated
targos
approved these changes
Sep 26, 2022
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
14 tasks
trivikr
reviewed
Sep 27, 2022
Comment thread
lib/internal/blob.js
This was referenced Sep 28, 2022
lpinca
approved these changes
Sep 30, 2022
jasnell
approved these changes
Oct 2, 2022
aduh95
approved these changes
Oct 10, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
trivikr
approved these changes
Oct 10, 2022
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44787 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating TextDecoder everytime blob.text() is called, we are now using a previously created decoder.