test: Verify request payload is uploaded consistently - #44801
Closed
98lenvi wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
98lenvi
force-pushed
the
issue-27880
branch
2 times, most recently
from
c73038f to
4032587
Compare
September 27, 2022 18:35
jasnell
reviewed
Oct 2, 2022
Comment thread
test/known_issues/test-http-clientrequest-end-contentlength.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
For new known-issue tests, there should a comment pointing to an open issue discussing the issue and it's very helpful to add a comment explaining why the test should be expected to fail.
Sorry, something went wrong.
Node.js seems to change how it is uploaded based on the method, but HTTP doesn't make any distinction.
Copy link
Copy Markdown
Contributor
|
I've pushed your changes to #34066 and added you as a co-author. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishing off the little bits pending in #34066. I've preserved the original contributor's commit. Let me know if I need to make a PR to the original branch instead, will then close this PR
Refs: #27880