FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove unused variable in addon test by joyeecheung · Pull Request #44809 · nodejs/node · GitHub

/ node Public

test: remove unused variable in addon test - #44809

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:remove-unused-isolate
Oct 2, 2022
Merged

test: remove unused variable in addon test#44809
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:remove-unused-isolate

Conversation

Copy link
Copy Markdown
Member

This fixes the compiler warning for the unused variable in the report-api addon test.

This fixes the compiler warning for the unused variable in the
report-api addon test.
nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2022
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

tniessen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 29, 2022

Copy link
Copy Markdown
Collaborator

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
nodejs-github-bot merged commit a16f81e into nodejs:main Oct 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in a16f81e

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
This fixes the compiler warning for the unused variable in the
report-api addon test.

PR-URL: #44809
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL