http: be more aggressive to reply 400, 408 and 431 - #44818
Merged
nodejs-github-bot merged 4 commits intoOct 6, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
As long as data of the in-flight response is not yet written to the socket, we can reply an error response without corrupting the client.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
ronag
reviewed
Sep 29, 2022
ronag
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM once CI failures are fixed
Sorry, something went wrong.
ShogunPanda
approved these changes
Sep 29, 2022
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
remove obsolete comment
lpinca
approved these changes
Sep 29, 2022
Comment thread
lib/_http_server.js
Outdated
fix comment Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
mcollina
approved these changes
Sep 30, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
rickyes
approved these changes
Oct 1, 2022
Copy link
Copy Markdown
Contributor
Author
|
Shall we proceed to get this PR landed? |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
As long as data of the in-flight response is not yet written to the socket, we can reply an error response without corrupting the client. PR-URL: #44818 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #37685, which is introduced in e8d7fed. It is too conservate (from the perspective from avoiding corrupting the client) to reply an error message.
Cases where we should reply an error message are covered in those 4 tests this PR modified, while the case where the socket should be immediately destroyed is covered in test/parallel/test-http-header-badrequest.js.