FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: check `--test` is disallowed in NODE_OPTIONS by cola119 · Pull Request #44846 · nodejs/node · GitHub

/ node Public

test: check --test is disallowed in NODE_OPTIONS - #44846

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cola119:add-disallowed-node-option-case
Oct 7, 2022
Merged

test: check --test is disallowed in NODE_OPTIONS#44846
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cola119:add-disallowed-node-option-case

Conversation

cola119 commented Oct 1, 2022

Copy link
Copy Markdown
Member

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 1, 2022
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2022

Copy link
Copy Markdown
Collaborator

daeyeon added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 2, 2022

Copy link
Copy Markdown
Collaborator

cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
nodejs-github-bot merged commit 2c57b94 into nodejs:main Oct 7, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2c57b94

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44846
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants


Back | FazBrowse Home | New Git URL